Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: <outdated hyperlinks of faq page> #4515

Closed
3 tasks done
M-AminAlizadeh opened this issue Apr 25, 2024 · 3 comments · Fixed by #4539
Closed
3 tasks done

Bug: <outdated hyperlinks of faq page> #4515

M-AminAlizadeh opened this issue Apr 25, 2024 · 3 comments · Fixed by #4539
Assignees
Labels
Status: Needs Review This issue/PR needs an initial or additional review Type: Bug Involves something that isn't working as intended

Comments

@M-AminAlizadeh
Copy link
Contributor

Checks

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the Bug: brief description of bug format, e.g. Bug: Lesson complete button does not update on click
  • Would you like to work on this issue?

Bug description

Hey there
I was checking the FAQ page and I realized in the question Which technologies can one expect to learn from The Odin Project? in the answer part some links like NodeJs, JavaScript, Ruby on Rails and other links are broken and when I click on them it redirects me to 404page

How to reproduce

  1. visit FAQ
  2. Check the below section
    image
  3. Click on underlined links like NodeJs, JavaScript, Ruby on Rails
  4. You will see below page
    image

Expected behavior

It should redirect a user to the proper pages in the curriculum

What browsers are you seeing the problem on?

Firefox

What OS are you using?

Ubuntu

Discord Name

Amin Alizadeh

Additional Comments

I can fix this error it's simple but important to UX

@M-AminAlizadeh M-AminAlizadeh added Status: Needs Review This issue/PR needs an initial or additional review Type: Bug Involves something that isn't working as intended labels Apr 25, 2024
@davidha99
Copy link
Contributor

I'm able to reproduce this issue on Chrome and Safari (MacOS), the broken links:

  • Foundations course
  • HTML and CSS
  • Javascript
  • NodeJS

@MaoShizhong
Copy link
Contributor

Sorry it's taken so long - thanks for raising this issue @M-AminAlizadeh, I've assigned this to you since you've specified you wish to work on this.
Let us know if you run into any issues.

MaoShizhong pushed a commit that referenced this issue May 28, 2024
<!-- Thank you for taking the time to contribute to The Odin Project. In
order to get this pull request (PR) merged in a reasonable amount of
time, you must complete this entire template. -->

## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it
solves or what benefit it provides. -->
This PR made to solve the specific issue that assigned me (#4515) in
this repo.


## This PR
<!-- A bullet point list of one or more items describing the specific
changes. -->

- All links in the faq page now working properly without any issues.

## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below
with the issue number, e.g. Closes #2013.

If this PR closes an open issue in another TOP repo, replace the #XXXXX
with the URL of the issue, e.g. Closes
https://github.com/TheOdinProject/curriculum/issues/XXXXX

If this PR does not close, but is related to another issue or PR, you
can link it as above without the 'Closes' keyword, e.g. 'Related to
#2013'.
-->
Closes #4515

## Additional Information
<!-- Any other information about this PR, such as a link to a Discord
discussion. -->


## Pull Request Requirements
<!-- Replace the whitespace between the square brackets with an 'x',
e.g. [x]. After you create the PR, they will become checkboxes that you
can click on. -->
- [x] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [x] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
    - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
    - `Fix` - bug fixes
-   [x] The `Because` section summarizes the reason for this PR
- [x] The `This PR` section has a bullet point list describing the
changes in this PR
- [x] I have verified all tests and linters pass after making these
changes.
- [x] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [ ] If applicable, this PR includes new or updated automated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This issue/PR needs an initial or additional review Type: Bug Involves something that isn't working as intended
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants