Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree-sitter perf #39

Open
WillLillis opened this issue Jan 16, 2024 · 1 comment · May be fixed by #43
Open

Tree-sitter perf #39

WillLillis opened this issue Jan 16, 2024 · 1 comment · May be fixed by #43

Comments

@WillLillis
Copy link
Contributor

WillLillis commented Jan 16, 2024

Regarding the "Gallons of perf" todo comment in htmx-lsp/lsp/src/tree-sitter.rs, I wanted to ask about taking an initial stab at some improvements regarding tree-sitter and the LSP's in-memory copy of the buffer(s) being edited. I've contributed a decent amount to asm-lsp (another LSP implemented in Rust), and was able to take advantage of both the LSP's incremental edits (as opposed to sending the entire document over with each change) as well as incremental parsing on the tree-sitter tree of the buffer in that project. If this sounds like it would be helpful, I'd love to spend some time implementing something similar here as a starting point :).

@WillLillis WillLillis linked a pull request Jan 22, 2024 that will close this issue
@savchenko
Copy link

@ThePrimeagen ?..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants