Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jellybeans diff sign colors are incomplete and hard to see #68

Open
ccope opened this issue Mar 1, 2022 · 2 comments · May be fixed by #69
Open

Jellybeans diff sign colors are incomplete and hard to see #68

ccope opened this issue Mar 1, 2022 · 2 comments · May be fixed by #69

Comments

@ccope
Copy link

ccope commented Mar 1, 2022

It appears the themer version of the Jellybeans theme is only setting foreground colors in the sign column? The problem is that they are hard to see. Jellybeans uses both foreground and background colors.

" sets the highlighting for the given group
fun! s:X(group, fg, bg, attr, lcfg, lcbg)

"...

call s:X("DiffAdd","D2EBBE","437019","","White","DarkGreen")
call s:X("DiffDelete","40000A","700009","","DarkRed","DarkRed")
call s:X("DiffChange","","2B5B77","","White","DarkBlue")
call s:X("DiffText","8fbfdc","000000","reverse","Yellow","")

-- https://github.com/nanotech/jellybeans.vim/blob/ef83bf4dc8b3eacffc97bf5c96ab2581b415c9fa/colors/jellybeans.vim#L522-L525

0oAstro pushed a commit that referenced this issue Mar 4, 2022
@0oAstro
Copy link
Collaborator

0oAstro commented Mar 4, 2022

@ccope Check the diff colors with the commit on dev branch

@0oAstro 0oAstro linked a pull request Mar 4, 2022 that will close this issue
@ccope
Copy link
Author

ccope commented Mar 4, 2022

@NarutoXy It still doesn't work, it seems like the fg values in this theme are the bg values from the original, and the bg is not being configured?

blkgoose pushed a commit to blkgoose/themer.lua that referenced this issue Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants