Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

click dependency not bounded #3

Open
ghost opened this issue Apr 12, 2022 · 2 comments
Open

click dependency not bounded #3

ghost opened this issue Apr 12, 2022 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 12, 2022

OS: Windows 10 21H2
Python: Python 3.10.4

Steps:

  • pip install "click<7"
  • pip install pyquotes

example.py

print("Hello, World!")

pyquotes --check example.py
pyquotes -D --check example.py

Both fail with the error

  File "C:\Python310\lib\site-packages\pyquotes\settings.py", line 96, in __init__
    super().__init__(**settings, project_root=project_root)
TypeError: _Config.__init__() got an unexpected keyword argument 'check'

This is resolved when using click>=8.

Thank you for your time, this library has saved my many hours.

@ThiefMaster
Copy link
Owner

Thanks, but I do not plan to support click 6. It's ancient (5 years old).

If there's a problem with recent click versions (7 or 8) that'd be something more worth fixing (ideally supporting both).

@ghost
Copy link
Author

ghost commented Apr 12, 2022

Thanks, but I do not plan to support click 6. It's ancient (5 years old).

If there's a problem with recent click versions (7 or 8) that'd be something more worth fixing (ideally supporting both).

Absolutely correct, but could you put a requirement on >=8? (the issue happens on 7.x as well) incase someone's environment has click already installed, it's currently an unbounded requirement.

Edit: Apologies, the issue isn't present on 7.x, so could requirements be updated to >=7 **

@ghost ghost mentioned this issue Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant