#374 - allow concurrent consumption of events #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachogiljaldo
force-pushed
the
374-allow_concurrent_consumption_of_events
branch
from
1cfa4da
to
dafe0de
Compare
nachogiljaldo
force-pushed
the
374-allow_concurrent_consumption_of_events
branch
from
7466597
to
c316ad9
Compare
|
Hey @m110 sorry for the direct ping, but I wonder if you could, as member of the org, review the PR or ask somebody who could do it. |
nachogiljaldo
force-pushed
the
374-allow_concurrent_consumption_of_events
branch
2 times, most recently
from
644709c
to
f528a17
Compare
nachogiljaldo
force-pushed
the
374-allow_concurrent_consumption_of_events
branch
from
f528a17
to
5c1acf0
Compare
|
@aldinugroho24 @yangyangrusli @m110 are you the maintainers of this repo? If yes, would you mind having a look at this PR? I think it would be a nice improvement. Also I wonder if you could use any help maintaining this repo. I see there's a bunch of piled PRs and I'm affected by some of those bugs, so I'd be happy to help if it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ThreeDotsLabs/watermill#374
Why?
It would be nice to have a simple way to increase the concurrency of message processing. With the current options, it is only possible to consume one message at the time (i.e. you need to get > process > ACK > get > process > ...).
That is not actually required in many use cases where events with the same key are sent to the same partition and, therefore, a partial order exists within the partition.
What?
This PR:
batchedMessageHandlerworks by collecting batches of messages up to a certain time or duration. Those messages are then sent to the output channel. NACKed messages are managed by resending every message following the NACKed one in that topic / partitionpartitionConcurrentMessageHandlerworks by multiplexing each claim into the output channel, that allows having up to N messages in-flight, where N is the number of topics/partitions in the subscriber. NACKs / ACKs are handled by each multiplexedIMPORTANT: I tried to preserve the current default behavior. Therefore, there is a
Defaultconsumption model which behaves the same way it does now.Potential follow-up
A potential follow-up would be a consumer that allows for up to N messages being in-flight. That would allow for cases in which the developers want to maximize parallelism at the expense of complexity on their code.