-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses old Nats. #381
Comments
https://github.com/ThreeDotsLabs/watermill-nats/tree/master/pkg/nats Use jetstream but not the new public api it has a stable api and also does things like ensure a topic / stream exists as well as better ordering guarantees |
I have an issue open right now to support the new API. #373 Right now I am thinking it would make the most sense to introduce a whole new package in Maybe it would be better to try and get the jetstream package added first and use upgrading the example as a test bed to suss out pain points etc.... |
Possibly of interest @gedw99 - ThreeDotsLabs/watermill-nats#13 I hope to have this passing tests in the not too distant future. But it is good enough to run the new example as is. |
hey @AlexCuse Your PR was merged and tagged at https://github.com/ThreeDotsLabs/watermill-nats/releases/tag/v2.0.2, so we can close this issue ? |
No I don't think so @gedw99 - the example you mention is still on the old STAN-based v1.0.7 and would need some updates to the way publishers and subscribers are bootstrapped to use the v2 api (whether using nats or jetstream package). Additionally its probably OK for use in an example but I would still consider the jetstream package experimental. There is a tricky race condition I have been chasing for awhile when I have time. It happens on almost every run in CI but is harder to replicate locally on decently spec'd hardware. I find if I run I am hoping the new |
thanks for the explanation @AlexCuse |
https://github.com/ThreeDotsLabs/watermill/tree/master/_examples/real-world-examples/server-sent-events
Needs upgrading to new nats jetstream public api: https://github.com/nats-io/nats.go/tree/main/jetstream
I have not checked what other examples use the old nats streaming yet
The text was updated successfully, but these errors were encountered: