Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[watermill-kafka] use github.com/IBM/sarama #388

Closed
jens1205 opened this issue Sep 6, 2023 · 2 comments
Closed

[watermill-kafka] use github.com/IBM/sarama #388

jens1205 opened this issue Sep 6, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@jens1205
Copy link

jens1205 commented Sep 6, 2023

The go.mod still says: require github.com/Shopify/sarama v1.38.0

The sarama lib is now available under https://github.com/IBM/sarama, this should be reflected in the go.mod (although there is some forwarding from https://github.com/shopify/sarama to https://github.com/IBM/sarama)
@d4nyll
Copy link

d4nyll commented Jan 28, 2024

otelsarama would also need to be replaced as it is deprecated. The most 'popular' (only?) replacement is dnwe/otelsarama. See also IBM/sarama#2510.

@henrik-olund-wcar
Copy link

I also want this.

@m110 m110 added the good first issue Good for newcomers label May 14, 2024
@m110 m110 closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@m110 @d4nyll @jens1205 @henrik-olund-wcar