New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect polish FULL_STANDALONE months name #55
Comments
ThreeTen-Backport gets the data for "standalone" months from the JDK, and that data is not available for JDKs before v9 if I remember correctly. |
Similar problems with Finnish locale. Standalone nominative month names end with "-kuu" and when inflected in partitive for non-standalone cases it becomes "-kuuta". Examples:
This gets even hairier when long localized dates are used, adding the "-ta" inflection suffix twice:
|
Similar problems with Russian locale. |
Same is going on with Catalan. I've made these simple tests: https://gist.github.com/sergiandreplace/29f995cd7a135484fa36ba05b6d0795e And the two last ones are failing, as LLLL is not returning Standalone months. In fact, I've checked the value of months for standalone format and they return non-standalone one. I'm not sure where is it taking from as I'm running it on an Android project. Being a unit tests is probably using the local jdk 8. Tested with android version of java.time libraries and it works. |
It uses the platform implementation of the DateTimeTextProvider SPI, see my comment here: #92 (comment) |
@sschaap It is correctly returned with the appropiate
But, using a format pattern with Using the old DateSimpleFormatter in Android:
Who is deciding to use not-standalone months for LLLL here? ThreeTenBP, Android or some other piece of software? Is this the expected behaviour? P.D.: ironically, in the java documentation the use of LLLL vs MMMM in catalan is set as an example for the SimpleDateFormat, but the DateTimeFormatter documentation has no mention about the difference between M and L. Thanks in advance |
Sorry, right now I've just re-read the second comment: #55 (comment) So it looks like the problem is that android still uses Java 8, isn' it? |
I've finally came up with this solution: https://github.com/sergiandreplace/androiddatetimetextprovider If anybody wants to try with another language.... |
In case of polish locale("pl", "PL"), the library returns incorrect translations.
Example:
returns
stycznia
(genitive) - should beStyczeń
(nominative, standalone)The correct translations are:
jan) stycznia -> Styczeń
feb) lutego -> Luty
mar) marca - > Marzec
apr) kwietnia -> Kwiecień
may) maja -> Maj
jun) czerwca -> Czerwiec
jul) lipca -> Lipiec
aug) sierpnia -> Sierpień
sep) września -> Wrzesień
oct) października -> Październik
nov) listopada -> Listopad
dec) grudnia -> Grudzień
The text was updated successfully, but these errors were encountered: