Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anyio support #97

Closed
wants to merge 9 commits into from
Closed

Add anyio support #97

wants to merge 9 commits into from

Conversation

uSpike
Copy link

@uSpike uSpike commented Mar 29, 2021

This would fix #96

Adds support for other async frameworks using anyio. The only thing to wait on is the release of anyio version 3, but I'd like to know if there's interest in this!

Cheers.

@Tinche
Copy link
Owner

Tinche commented Mar 29, 2021

I wouldn't mind having this in tbh!

@uSpike
Copy link
Author

uSpike commented Apr 23, 2021

Anyio 3.0 is out, and this PR is rebased and ready for review @Tinche

@uSpike
Copy link
Author

uSpike commented Apr 23, 2021

Of note, I had to increase the minimum python version to 3.6.2 to match anyio requirements.

@uSpike
Copy link
Author

uSpike commented Apr 23, 2021

Actually, upon further inspection some tests are failing after that rebase. Will investigate.

@uSpike
Copy link
Author

uSpike commented Apr 23, 2021

Frankly, the loop keyword argument for various functions should be deprecated or removed. It was deprecated in python 3.8 and removed in 3.10.

@uSpike
Copy link
Author

uSpike commented Apr 23, 2021

OK, should be good now. The entirety of /src/aiofiles/tempfile/__init__.py was rewritten with correct line-endings. It was added with Windows style line endings, so I changed it with dos2unix to match the other files.

@Tinche
Copy link
Owner

Tinche commented Apr 23, 2021

I opened an issue over at agronholm/anyio#266 asking for clarification since I see anyio already has async file IO support.

@Tinche
Copy link
Owner

Tinche commented Sep 20, 2021

Looks like anyio has no actual interest in this, so I'm going to pass. Sorry!

@Tinche Tinche closed this Sep 20, 2021
@uSpike
Copy link
Author

uSpike commented Sep 20, 2021

@Tinche i'm confused, you were looking to integrate aiofiles into anyio? That was not my intention here. With this PR you could enable users of asyncio and Trio to use aiofiles. Why close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anyio/trio support
2 participants