Setuptools is required at run-time, not just build-time #1191
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we relied on the fact that setuptools must be installed at build-time to ensure that it was also available at run-time. However, unless setuptools is explicitly listed as a run-time dependency, there's no guarantee that it won't be uninstalled. Package managers like Spack only add run-time dependencies to
PYTHONPATH
, so this distinction becomes even more important.I'm not sure what versions of setuptools are required, but let me know if you want me to add an upper/lower bound.