Skip to content

Setuptools is required at run-time, not just build-time #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

adamjstewart
Copy link
Contributor

Previously, we relied on the fact that setuptools must be installed at build-time to ensure that it was also available at run-time. However, unless setuptools is explicitly listed as a run-time dependency, there's no guarantee that it won't be uninstalled. Package managers like Spack only add run-time dependencies to PYTHONPATH, so this distinction becomes even more important.

I'm not sure what versions of setuptools are required, but let me know if you want me to add an upper/lower bound.

@rbuffat
Copy link
Contributor

rbuffat commented Jan 31, 2023

As far as I understand there should be no run-time dependency of Fiona on setuptools.

@adamjstewart
Copy link
Contributor Author

@sgillies
Copy link
Member

sgillies commented Jan 31, 2023

Yes, that's it, CLI command discovery depends on setuptools's pkg_resources. If you install fiona with pip or use conda, you'll have pkg_resources (for now), which is why our tests continued to pass, but that's not the case for Spack.

@sgillies sgillies added this to the 1.9.1 milestone Jan 31, 2023
@sgillies sgillies added the bug label Jan 31, 2023
@sgillies sgillies merged commit 604cd01 into Toblerity:master Jan 31, 2023
@adamjstewart adamjstewart deleted the deps/setuptools branch January 31, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants