Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle stays enlarged when tapped during drag of parent view #69

Open
FinnGu opened this issue Jul 4, 2017 · 0 comments
Open

Handle stays enlarged when tapped during drag of parent view #69

FinnGu opened this issue Jul 4, 2017 · 0 comments

Comments

@FinnGu
Copy link

FinnGu commented Jul 4, 2017 •
edited

As the title says, if you tap a handle during drag of parent view, it will stay enlarged until tapped or dragged again.

Steps to reproduce:

  1. Create ViewController with ScrollView and ContentView
  2. Add TTRangeSlider to ContentView
  3. Enable alwaysBounceVertical on ScrollView
  4. Drag ScrollView up or down to bounce it and while it returns to original position, try to tap or drag a handle
696GrocuttT added a commit to 696GrocuttT/TTRangeSlider that referenced this issue Jul 13, 2019
@696GrocuttT
Fixed interaction with gesture recognizers
217eef2 
If the range slider is placed on a view with a gesture recognizer (eg a scroll view)
the gesture recognizer can grab touch events making the slider difficult to control.
The Apple documentation for the UIView gestureRecognizerShouldBegin method mentions
that this method is used by UISlider to overcome this issue, so this is the approach
this patch uses.

The new page sheet presentation style in iOS 13 makes it more likely that the view
the range slider is on will have a gesture recognizer, and therefore be effected by
this problem.

While debugging this issue similar symptoms to issue TomThorpe#69 ("Handle stays enlarged
when tapped during drag of parent view") were encountered and fixed. The exact
reproduction steps described in issue 69 haven't been retested, but it's possible
this patch also fixes that issue.
@696GrocuttT 696GrocuttT mentioned this issue Jul 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FinnGu