Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add setDefaultBuildOption to support emoji when building plist #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add setDefaultBuildOption to support emoji when building plist #53

wants to merge 2 commits into from

Conversation

flyingsky
Copy link

fix #52

@flyingsky
Copy link
Author

why fail test?

@TooTallNate
Copy link
Owner

Needs a regression test.

@mreinstein
Copy link
Collaborator

@flyingsky sorry for the incredibly long delay in follow up, but I'm here cleaning up this module. If you can provide test(s) that demo what this PR is fixing, I'm happy to review it in a timely fashion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw error for emoji
3 participants
@flyingsky @TooTallNate @mreinstein