[pac-proxy-agent] Add servername to tls options when connecting in DI…

…RECT (#159)
TooTallNate · May 9, 2023 · bf20b04 · bf20b04 · vercel · May 9, 2023
1 parent 63adbce
commit bf20b04
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/.changeset/stupid-queens-listen.md b/.changeset/stupid-queens-listen.md
@@ -0,0 +1,5 @@
+---
+'pac-proxy-agent': patch
+---
+
+Add `servername` to tls connection options when pac-proxy-agent results in DIRECT connection
diff --git a/packages/pac-proxy-agent/src/index.ts b/packages/pac-proxy-agent/src/index.ts
@@ -232,7 +232,15 @@ export class PacProxyAgent<Uri extends string> extends Agent {
 
 			if (type === 'DIRECT') {
 				// Direct connection to the destination endpoint
-				socket = secureEndpoint ? tls.connect(opts) : net.connect(opts);
+				if (secureEndpoint) {
+					const servername = opts.servername || opts.host;
+					socket = tls.connect({
+						...opts,
+						servername: (!servername || net.isIP(servername)) ? undefined : servername,
+					});
+				} else {
+					socket = net.connect(opts);
+				}
 			} else if (type === 'SOCKS' || type === 'SOCKS5') {
 				// Use a SOCKSv5h proxy
 				agent = new SocksProxyAgent(`socks://${target}`, this.opts);