Update debug to v4.0.0
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
pushed a commit
that referenced
this pull request
Oct 17, 2019
TooTallNate
pushed a commit
that referenced
this pull request
Oct 17, 2019
TooTallNate
pushed a commit
that referenced
this pull request
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/visionmedia/debug/releases/, it looks like there have been no breaking changes between debug 3.x and debug 4.x, except implicitly in the Node engine it supports. It now requires Node 6 (or higher), and no longer supports Node 4.
It looks like this package already requires Node 6, so that should be fine. I've updated the
enginesproperty in a separate commit to reflect this.I'm proposing
^4.0.0instead of explicitly requiring the latest point version (currently 4.1.1) because there have been no security fixes in-between, and no new features thatnode-https-proxy-agentdepends on.By default, this will do the same either way and uses the latest. But, it has the benefit of allowing de-duplication in downstream user applications with other packages that might be using an older 4.x version.
Ref puppeteer/puppeteer#5026.