Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of CPD #103

Open
sixtoad opened this issue Jun 23, 2015 · 3 comments
Open

Implementation of CPD #103

sixtoad opened this issue Jun 23, 2015 · 3 comments

Comments

@sixtoad
Copy link

sixtoad commented Jun 23, 2015

Hi TouK,
I have implemented CPD (PMD subproject) because we want to check if somebody had been copy and paste of previous code, I don´t know if you would be interested in it, it is really fast and my current implementation check all code that CPD can analyze in the directory, sending back the violations with references to duplicated files. If you are interested in it I can write some test and send to you a push.
In last versions of gerrit, you can comment a block of code, but currently is not supported by sputnik, with CPD will be very useful to mark a block of code instead to show only a comment with the number of lines detected in the beginning of the block would you interested to an implementation of this?. I am thinking that could support both ways to send violations, to make compatible with previous versions (and other plugins could use it too).

@SpOOnman
Copy link
Collaborator

Is this a separate project? I thought PMD has duplicate code detection enabled by default.

Do you have a version working with Sputnik and Gerrrit? Does it work fine? Does it duplicate with PMD?

Any information and contributions are appreciated. Thanks!

@SpOOnman
Copy link
Collaborator

@sixtoad I'd like to see your implementation of CPD. We can work out on including it in Sputnik. Are you still interested in it?

@sixtoad
Copy link
Author

sixtoad commented Feb 26, 2016

HI, sorry, I was working on it (adding more tests, because didn't have a good coverage and I discovered boundaries errors), I need to get back to it, because I need to put in production in our systems...you can take a look in my fork (I used CPD of PMD wich is not enabled, you have to use it separately. I'll try to improve it (and merge current master branch) on next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants