Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dry-run option? #84

Open
JKrag opened this issue Apr 27, 2015 · 2 comments
Open

dry-run option? #84

JKrag opened this issue Apr 27, 2015 · 2 comments

Comments

@JKrag
Copy link

JKrag commented Apr 27, 2015

Hi TouK
I have recently been using your tool, and integrating it in a CD pipeline on Jenkins.
During my testing and experimenting with reasonable configurations, I ran sputnik from command line on my local machine (usually on already closed change-sets).
For this purpose, It would have been a great help to have a --dry-run option that did the whole analysis, but skipped reporting back to Gerrit.
I actually started working on a pull-request, and have added the CliOption, but couldn't really figure out the 'correct' way to introduce the "no reporting" part in a generic matter.

Would you consider adding this feature? (I would happily send you my partial pull-request, but it is really only a couple of lines of code, and you can probably write those faster than pulling a PR).

Regards Jan

@SpOOnman
Copy link
Collaborator

Hi Jan

What's the point of dry run if you don't report it to Gerrit? You want to see results in console?

@JKrag
Copy link
Author

JKrag commented Apr 29, 2015

Exactly. While I am experimenting with settings or tweaking things like check style settings, I might have to run the tool many times (from the console), and don't want to "spam" Gerrit with comments.
I might also use the option temporarily while setting up Sputnik on a Jenkins pipeline, to make sure the Gerrit triggers and paths are set up correctly.

In the really ideal nice-to-have world, it would be nice if dry-run did some sort of pretty print to the console (like line by line), but not really that important.

Hope this makes sense.

Cheers, Jan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants