Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate code in visualizer #59

Open
manon-traverse opened this issue Sep 7, 2021 · 2 comments
Open

Deduplicate code in visualizer #59

manon-traverse opened this issue Sep 7, 2021 · 2 comments

Comments

@manon-traverse
Copy link
Collaborator

The visualizer code is very low quality at the moment. There is lots of duplication between the D3D12 and Vulkan variants. We should unify these more.
@MarijnS95 MarijnS95 mentioned this issue Sep 19, 2021
Merged
@MarijnS95
Copy link
Member

@tosti007 it looks like you did exactly this in #176? Can we link the PR and close this?

@tosti007
Copy link
Contributor

tosti007 commented Oct 4, 2023 •
edited

Not fully, there's still some duplicated code, but solving that requires a larger overhaul regarding how the visualizations are done. I think the way forward would be to define some "output stats sctructs" that you can obtain from the allocator, which can then be passed into a single shared visualizer.

@Jasper-Bekkers Jasper-Bekkers mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MarijnS95 @tosti007 @manon-traverse