Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering release issue in semantic-release #199

Closed
leventozen opened this issue Aug 15, 2022 · 2 comments
Closed

Triggering release issue in semantic-release #199

leventozen opened this issue Aug 15, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@leventozen
Copy link
Member

leventozen commented Aug 15, 2022

In this pr, it should create new release according to semantic-release documentation. However, it didn't. We have ! and breaking change message, that should be considered to fix this issue.

@muratcorlu
Copy link
Contributor

muratcorlu commented Aug 15, 2022

We are already in a beta channel of a major release(v2.0). Any breaking change in the next branch until we have a stable release of v2 will not trigger another major release. If this was the issue ☺️

@leventozen
Copy link
Member Author

leventozen commented Aug 15, 2022

Actually the case is semantic-release didn’t release anything after our commit (with ! and breaking change message), so I created this issue but I didn’t have time to look at it yet. However, thanks for your comment @muratcorlu, tomorrow I will define the issue more detailed.

@leventozen leventozen changed the title Triggering major release issue in semantic-release Triggering release issue in semantic-release Aug 16, 2022
@batuhantozun batuhantozun added the enhancement New feature or request label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants