Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generic modal #98

Open
hanifisenturk opened this issue Feb 4, 2024 · 1 comment
Open

Implement generic modal #98

hanifisenturk opened this issue Feb 4, 2024 · 1 comment

Comments

@hanifisenturk
Copy link
Contributor

hanifisenturk commented Feb 4, 2024

Hi! @armagandalkiran, @aahmetcakir!
https://www.figma.com/file/3Rvo2R5AWAse3O09KtuhZT/GurubuV2?type=design&node-id=73-9675&mode=design&t=qoRnfA7F8ifD6tbe-4

I've observed that there's a modal designed for updating user nicknames. However, we have the opportunity to enhance its dynamism. By utilizing ContextAPI, we can manage this modal using just one instance. Currently, the modal lacks confirm or cancel buttons, but we can incorporate them in the future and manage their functionality through custom onConfirm and onCancel functions.

Let me illustrate this with a simple API example:
carbon

Despite the current absence of proper confirm and cancel buttons in the design, we can utilize a custom closeModal function to close the modal once the associated logic is completed.

And you can assign it to me if you want. 🚀

@armagandalkiran
Copy link
Collaborator

We did not open issue about the popup yet so if you would like to implement this behavior you are more then welcome to do it. After this implementation done we can open issue about the implementation of nickname change popup. Of course i can assign it to you if you want to do it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants