We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
In version v3.12.0 even if I set the input skip-ci to false or "false" , the action continue to add [skip-ci] part into the commit message.
skip-ci
false
"false"
[skip-ci]
I saw that at the line : https://github.com/TriPSs/conventional-changelog-action/blob/releases/v3/src/index.js#L46 We have
const skipCi = core.getInput('skip-ci')
while with the other inputs of "type" boolean are processed like this
const skipGitPull = core.getInput('skip-git-pull').toLowerCase() === 'true'
It seems like getInput method always return a string so this part of code is always reached (https://github.com/TriPSs/conventional-changelog-action/blob/releases/v3/src/index.js#L48)
getInput
if (skipCi) { gitCommitMessage += " [skip ci]" }
If you want to keep a "pure" boolean for this input, I think that you have to use the getBooleanInput method instead of getInput : https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md#130
getBooleanInput
The text was updated successfully, but these errors were encountered:
Good catch! Will check if I can fix this today.
Sorry, something went wrong.
ae32d56
No branches or pull requests
Hi,
In version v3.12.0 even if I set the input
skip-ci
tofalse
or"false"
, the action continue to add[skip-ci]
part into the commit message.I saw that at the line : https://github.com/TriPSs/conventional-changelog-action/blob/releases/v3/src/index.js#L46
We have
while with the other inputs of "type" boolean are processed like this
It seems like
getInput
method always return a string so this part of code is always reached (https://github.com/TriPSs/conventional-changelog-action/blob/releases/v3/src/index.js#L48)If you want to keep a "pure" boolean for this input, I think that you have to use the
getBooleanInput
method instead ofgetInput
: https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md#130The text was updated successfully, but these errors were encountered: