Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

variables.css isn't exported in build #337

Open
ggascoigne opened this issue Nov 29, 2018 · 2 comments
Open

variables.css isn't exported in build #337

ggascoigne opened this issue Nov 29, 2018 · 2 comments

Comments

@ggascoigne
Copy link
Member

The file src/styles/variables.css is striped of everything interesting by the build, if it was copied over intact then client css or scss could import it directly. This would make it easier for client apps to share constants.

@andrewleyva
Copy link
Collaborator

I'm of the opinion that we should refactor this to be LESS (and then still export the variables file). But that's probably out of scope for this.

@ggascoigne
Copy link
Member Author

I don't particularly mind about the refactoring, I just want a css or sccs compatible file (like the original one that's checked in), that I can import directly into my code.

Truth be told a sccs file would be more useful, so maybe exposing both flavors would be nice, since sccs gives a deprecation warning if you import a css file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants