From 8b344ae4c23ad6bd2a3e2927e95595011c1ff289 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Tue, 16 Jul 2019 14:45:29 -0700 Subject: [PATCH] src: expose TraceEventHelper with NODE_EXTERN As node requires a tracing controller to be initialized embedders need access to the TraceEventHelper so that we can actually set the tracing controller. Refs: https://github.com/electron/electron/commit/0e5b6f93000e4718c9e35332ddbd0f6b76cdd585/#diff-89b287b2edd0a02dddae60cb26157f47 PR-URL: https://github.com/nodejs/node/pull/28724 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Rich Trott --- src/tracing/trace_event.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/tracing/trace_event.h b/src/tracing/trace_event.h index 590cb592fc054f..27408eafd832ae 100644 --- a/src/tracing/trace_event.h +++ b/src/tracing/trace_event.h @@ -310,7 +310,9 @@ const int kZeroNumArgs = 0; const decltype(nullptr) kGlobalScope = nullptr; const uint64_t kNoId = 0; -class TraceEventHelper { +// Extern (for now) because embedders need access to TraceEventHelper. +// Refs: https://github.com/nodejs/node/pull/28724 +class NODE_EXTERN TraceEventHelper { public: static TracingController* GetTracingController(); static Agent* GetAgent();