Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no value to be a regular expression #153

Open
Trott opened this issue Aug 10, 2021 · 0 comments
Open

Allow no value to be a regular expression #153

Trott opened this issue Aug 10, 2021 · 0 comments

Comments

@Trott
Copy link
Owner

Trott commented Aug 10, 2021

That would be a good enhancement. of all the remark-lint plugins I used over the last couple of days, this is the most useful and fun to use! I wrote a rule for contractions and thought the same - using the group would be useful there. E.g. { no: "\\w+'ll", yes: '$1 will' } to "they'll" => "they will". In a related matter, I couldn't enter "no" regex directly (had to be a string). I was trying to do a negative look behind /(?<!foo)bar/i, but the plugin does string manipulation on the rule and it screws up the expression. It's not clear the rules must be strings, but it'd be nice if they didn't have to be.

Originally posted by @wickedest in #76 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant