Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put gulp in fire #1149

Closed
2 of 5 tasks
nicksellen opened this issue Dec 13, 2019 · 0 comments
Closed
2 of 5 tasks

Put gulp in fire #1149

nicksellen opened this issue Dec 13, 2019 · 0 comments

Comments

@nicksellen
Copy link
Contributor

nicksellen commented Dec 13, 2019

From #791

The idea is to remove gulp. It doesn't really need replacing with anything either, as mostly the build/test tools we use have their own standalone versions, and the scripts in package.json are mostly sufficient to run them.

A lot of stuff is done via gulp:

  • for dev
    • configure environment
    • run main server with nodemon
    • run worker (aka agenda) with nodemon
    • build less/css
    • build angular templates
    • build fontella font(s)
    • run webpack for main code
    • run webpack for service worker code
    • run tests
    • watch file changes for most of the above to re-run commands on change
  • for prod
    • build assets
    • run server
    • run worker

A general idea for post-gulp world:

  • rely more on build/test tools for file watching (webpack, jest - depending on Add react tests #1147, mocha), as they can do it more fine grained than the current manual configuration approach
  • move as much into webpack (+ dev server with hot reloading and nice overlay errors) as possible (less/css, fonts, angular templates, frontend linting)
  • not so sure about the server, linting as part of server running? not sure that's normally done, maybe keep to standalone server linting script (esw or similar), let's see...

That kind of thing anyway...

Related issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants