From 0bfc486ec3eba6e3ce592cfcc07792c4b32ecbda Mon Sep 17 00:00:00 2001 From: Daniel Lockyer Date: Tue, 19 Mar 2024 11:02:04 +0100 Subject: [PATCH] Added support for Node 20 ref https://linear.app/tryghost/issue/ENG-765/add-support-for-node-20 - this adds support for Node 20 to Ghost and CI, as Node 20 is an LTS version --- .github/workflows/ci.yml | 4 ++-- ghost/admin/package.json | 4 ++-- ghost/core/package.json | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d92898902190..e41f05414bca 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -417,7 +417,7 @@ jobs: if: needs.job_get_metadata.outputs.changed_any_code == 'true' strategy: matrix: - node: [ '18.12.1' ] + node: [ '18.12.1', '20.11.1' ] name: Unit tests (Node ${{ matrix.node }}) steps: - uses: actions/checkout@v4 @@ -455,7 +455,7 @@ jobs: if: needs.job_get_metadata.outputs.changed_core == 'true' strategy: matrix: - node: [ '18.12.1' ] + node: [ '18.12.1', '20.11.1' ] env: - DB: mysql8 NODE_ENV: testing-mysql diff --git a/ghost/admin/package.json b/ghost/admin/package.json index 7b922efbf1ef..aed93eda70c3 100644 --- a/ghost/admin/package.json +++ b/ghost/admin/package.json @@ -26,7 +26,7 @@ "lint": "yarn lint:js && yarn lint:hbs" }, "engines": { - "node": "^18.12.1" + "node": "^18.12.1 || ^20.11.1" }, "devDependencies": { "@babel/eslint-parser": "7.23.3", @@ -201,4 +201,4 @@ } } } -} \ No newline at end of file +} diff --git a/ghost/core/package.json b/ghost/core/package.json index da6387df63b4..3307f918be9d 100644 --- a/ghost/core/package.json +++ b/ghost/core/package.json @@ -53,8 +53,8 @@ "prepack": "node monobundle.js" }, "engines": { - "node": "^18.12.1", - "cli": "^1.25.0" + "node": "^18.12.1 || ^20.11.1", + "cli": "^1.26.0" }, "dependencies": { "@extractus/oembed-extractor": "3.2.1",