From 682a770bf92c4e1c22a2982f05bf0a31c1bc6a59 Mon Sep 17 00:00:00 2001 From: Daniel Lockyer Date: Tue, 19 Mar 2024 11:02:04 +0100 Subject: [PATCH] =?UTF-8?q?=E2=84=B9=EF=B8=8F=20Added=20support=20for=20No?= =?UTF-8?q?de=2020?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ref https://linear.app/tryghost/issue/ENG-765/add-support-for-node-20 - this adds support for Node 20 to Ghost and CI, as Node 20 is an LTS version and we should pick it up --- .github/workflows/ci.yml | 4 ++-- ghost/admin/package.json | 2 +- ghost/core/package.json | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 071978a776c7..ef450b50bf40 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -417,7 +417,7 @@ jobs: if: needs.job_get_metadata.outputs.changed_any_code == 'true' strategy: matrix: - node: [ '18.12.1' ] + node: [ '18.12.1', '20.11.1' ] name: Unit tests (Node ${{ matrix.node }}) steps: - uses: actions/checkout@v4 @@ -455,7 +455,7 @@ jobs: if: needs.job_get_metadata.outputs.changed_core == 'true' strategy: matrix: - node: [ '18.12.1' ] + node: [ '18.12.1', '20.11.1' ] env: - DB: mysql8 NODE_ENV: testing-mysql diff --git a/ghost/admin/package.json b/ghost/admin/package.json index a42fa0d49b82..7c66f4e95eed 100644 --- a/ghost/admin/package.json +++ b/ghost/admin/package.json @@ -26,7 +26,7 @@ "lint": "yarn lint:js && yarn lint:hbs" }, "engines": { - "node": "^18.12.1" + "node": "^18.12.1 || ^20.11.1" }, "devDependencies": { "@babel/eslint-parser": "7.23.3", diff --git a/ghost/core/package.json b/ghost/core/package.json index 1c51bf386b89..376faab25a54 100644 --- a/ghost/core/package.json +++ b/ghost/core/package.json @@ -53,8 +53,8 @@ "prepack": "node monobundle.js" }, "engines": { - "node": "^18.12.1", - "cli": "^1.25.0" + "node": "^18.12.1 || ^20.11.1", + "cli": "^1.26.0" }, "dependencies": { "@extractus/oembed-extractor": "3.2.1",