Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 5.0.4 cannot be built on FreeBSD #1584

Closed
2510 opened this issue Apr 21, 2022 · 3 comments
Closed

version 5.0.4 cannot be built on FreeBSD #1584

2510 opened this issue Apr 21, 2022 · 3 comments

Comments

@2510
Copy link

2510 commented Apr 21, 2022

On FreeBSD, version 5.0.4 cannot be built. Version 5.0.3 can be built successfully.

System Info:

% uname -a
FreeBSD sugar.local 13.0-RELEASE-p3 FreeBSD 13.0-RELEASE-p3 #0: Tue Jun 29 19:46:20 UTC 2021     root@amd64-builder.daemonology.net:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64
% cc --version
FreeBSD clang version 11.0.1 (git@github.com:llvm/llvm-project.git llvmorg-11.0.1-0-g43ff75f2c3fe)
Target: x86_64-unknown-freebsd13.0
Thread model: posix
InstalledDir: /usr/bin

Build log: (from npm install)

> sqlite3@5.0.4 install /usr/home/2510/test/node_modules/sqlite3                                                                                                              
> node-pre-gyp install --fallback-to-build                                                                                                                                           
                                                                                          
node-pre-gyp ERR! install response status 404 Not Found on https://github.com/TryGhost/node-sqlite3/releases/download/v5.0.4/napi-v6-freebsd-unknown-x64.tar.gz    
node-pre-gyp WARN Pre-built binaries not installable for sqlite3@5.0.4 and node@16.10.0 (node-v93 ABI, unknown) (falling back to source compile with node-gyp) 
node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/TryGhost/node-sqlite3/releases/download/v5.0.4/napi-v6-freebsd-unknown-x64.tar.gz 
(node:96089) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
(Use `node --trace-deprecation ...` to show where the warning was created)
gmake: Entering directory '/usr/home/2510/test/node_modules/sqlite3/build'         
  CC(target) Release/obj.target/nothing/../node-addon-api/nothing.o                       
  AR(target) Release/obj.target/../node-addon-api/nothing.a    
  COPY Release/nothing.a                                                                                                                                                             
  ACTION deps_sqlite3_gyp_action_before_build_target_unpack_sqlite_dep Release/obj/gen/sqlite-autoconf-3380200/sqlite3.c
  TOUCH Release/obj.target/deps/action_before_build.stamp 
  CC(target) Release/obj.target/sqlite3/gen/sqlite-autoconf-3380200/sqlite3.o
In file included from <built-in>:1:                                                       
./../src/gcc-preinclude.h:5:10: fatal error: 'features.h' file not found 
#include <features.h>                                                                     
         ^~~~~~~~~~~~                                                                     
1 error generated.  

Following commit may be related:
73da410

daniellockyer added a commit that referenced this issue Apr 21, 2022
refs #1584

- on freebsd, `features.h` is missing so the library will fail to compile
- we actually only want to include these symbol overrides if we're on Linux,
  so this commit moves the checks around to tighten up the flow
- a further iteration could remove the file from `bindings.gyp` if I can
  figure out how to only use it in CI
@daniellockyer
Copy link
Member

daniellockyer commented Apr 21, 2022

Hey @2510 🙂 Does the following work for you now?

npm install https://github.com/tryghost/node-sqlite3/tarball/master

@2510
Copy link
Author

2510 commented Apr 21, 2022

npm install https://github.com/tryghost/node-sqlite3/tarball/master

It worked! Thank you for quick response.

@daniellockyer
Copy link
Member

Excellent! A new release will be out soon 🙂

This was referenced Apr 22, 2022
This was referenced Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants