Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress 5.3 compatibility #18

Open
nuclearpengy opened this issue Nov 9, 2019 · 5 comments
Open

WordPress 5.3 compatibility #18

nuclearpengy opened this issue Nov 9, 2019 · 5 comments
Assignees

Comments

@nuclearpengy
Copy link
Collaborator

WordPress 5.3 is scheduled to be released on 12 November 2019. Test the plugin with WordPress 5.3 and ensure it's compatible.

Areas to focus on:

  1. Admin CSS changes and recommendations (https://make.wordpress.org/core/2019/10/18/noteworthy-admin-css-changes-in-wordpress-5-3/) as well as the reduction of block editor CSS (https://make.wordpress.org/core/2019/09/27/block-editor-theme-related-updates-in-wordpress-5-3/).
  2. Changes to the WP_MS_Sites_List_Table class: https://make.wordpress.org/core/2019/10/15/enhancements-to-the-network-sites-screen-in-wordpress-5-3/.
  3. Potential impact if a plugin extends certain classes and overloads certain methods in the spread operator: https://make.wordpress.org/core/2019/10/09/wp-5-3-introducing-the-spread-operator/.
  4. Support for PHP 7.4 and recommendation to add the PHPCompatibility checker to help detect PHP version compatibility issues in PHP 7.4: https://make.wordpress.org/core/2019/10/11/wordpress-and-php-7-4/.
  5. Changes to wp_die(): https://make.wordpress.org/core/2019/10/15/changes-to-wp_die-html-output-in-wordpress-5-3/.
  6. Various plugin recommendations: https://make.wordpress.org/core/2019/10/15/miscellaneous-developer-focused-changes-in-5-3/.
@nuclearpengy nuclearpengy self-assigned this Nov 9, 2019
@jameshome
Copy link

Any ETA on this? I just tried to install the plug in on a client's WP 5.3.2 install and it failed with:
The plugin ghost/ghost.php has been deactivated due to an error: Plugin file does not exist.

@nuclearpengy
Copy link
Collaborator Author

hi @jameshome - The current version is working with 5.3.2. I just need to check a few things before resolving/closing this issue.

Did you download this version https://wordpress.org/plugins/ghost/ ?

@csotiriou
Copy link

csotiriou commented Feb 9, 2020

Actually, I have the plugin installed in version 5.3.2, and when I click on the "zip" or "json" links, I get presented with a white screen, and nothing else happens.

Is there any plugin that could collide with this one?

@jameshome
Copy link

@nuclearpengy thanks for the quick response and sorry I entirely missed it until now!

I did indeed try to install that version. I tried several times and had no luck. I moved on to another part of the project and promptly forgot all about it until Friday, when I tried again and it installed just fine. Yay!

Unfortunately, it would neither give me the zip or json files, instead erroring with a Wordpress fatal. Boo.

I don't presently have access to the Wordpress debug logs, so your guess is better than mine what the problem is, but that seems like it's my problem to deal with and unlikely to be a plug-in bug. Thanks again!

@csotiriou
Copy link

@jameshome hi, for some reason it worked.

The changes I made were to activate php 7.4, and disable 7.3. For some reason, the zip file just worked as expected,

PaulAdamDavis added a commit that referenced this issue Feb 10, 2021
Refs #18

- Removes calls for Open Sans webfont
- Removes many custom styles, opting to use WP defaults
- Fixes Ghost icon display
- Updates screenshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants