Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Response 중 success 필드를 제거하는게 좋을까요? #35

Open
truman-show opened this issue May 15, 2021 · 1 comment
Open

Comments

@truman-show
Copy link
Collaborator

개요

  • API Response Body 필드 중 boolean type success 필드는 제거할까요?

이슈 내용

  • 아래 이미지와 같이 용진님께서 제거하는건 어떨지 의견을 주셨습니다.
  • 용진님 의견을 듣고 생각해보니 http status 응답으로도 충분히 판단히 가능할거라는 생각이 듭니다.
  • 프론트엔드 @onemask 님 의견은 어떠신가요?

image

@truman-show
Copy link
Collaborator Author

굳이 ApiResponseModel 객체를 만들 필요도 없겠다 라는 생각이 드네요.

data 에 대한 응답만 하는거죠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant