Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# ValidateTwilioRequestAttribute check flipped? #842

Open
c17r opened this issue Oct 2, 2020 · 0 comments
Open

C# ValidateTwilioRequestAttribute check flipped? #842

c17r opened this issue Oct 2, 2020 · 0 comments

Comments

@c17r
Copy link

c17r commented Oct 2, 2020

Perhaps I'm misunderstanding, but this line:

api-snippets/guides/request-validation-csharp-core/example-3/example-3.cs

Line 32 in 2855c5c

if (!IsValidRequest(context.Request) || !IsTestEnvironment)

Shouldn't that be if (!IsValidRequest(context.Request) && !IsTestEnvironment)? If the request is not valid and we're not in the test environment, then give the 403.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c17r and others