multiple non-consecutive signers issue

[ctubio]

🎁 hiii

i do believe the following function works nice for groups with a single signer or with multiple consecutive, liike:

• txn0: signerA

or

• utxn0: signerA
• stxn1: signerB
• stxn2: signerB

is returned as-is

but in case of non-consecutive, it returns duplicated txns and while duplicating misses the txn on each replaced index, liike:

• utxn0: signerA
• stxn1: signerB
• utxn2: signerA

is returned as:

• utxn0: signerA
• stxn1: signerB
• stxn1: signerB

(note utxn2 is lost and replaced by a duplicated stxn1)

(note² in the examples, signerA will sign a txn, and signerB already signed it so will not sign nothing on this request)

use-wallet/src/clients/pera/client.ts

Lines 204 to 213 in 380bd15

	const signedTxns = transactions.reduce<Uint8Array[]>((acc, txn, i) => {
	if (signedIndexes.includes(i)) {
	const signedByUser = result.shift()
	signedByUser && acc.push(signedByUser)
	} else if (returnGroup) {
	acc.push(transactions[i])
	}
	return acc
	}, [])

thank you for your awesome work'¡