Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the returnGroup argument and logic from signTransactions #160

Open
drichar opened this issue Apr 10, 2024 · 0 comments
Open

Remove the returnGroup argument and logic from signTransactions #160

drichar opened this issue Apr 10, 2024 · 0 comments
Assignees
Labels
feature request New feature or enhancement v3

Comments

@drichar
Copy link
Collaborator

drichar commented Apr 10, 2024

This is a holdover from the original MyAlgo implementation (pre ARC-0001) that only supported signatures by a single account per group.

NFDomains requires signatures from two accounts to verify a linked address, so our solution was to return the entire group (not just the signed transactions) so a second signing request could be initiated.

This is no longer necessary, and adds unnecessary complexity to the library's signing logic. It also breaks with the ARC-0001 SignTxnsFunction type signature by returning unsigned transactions.

@drichar drichar added the feature request New feature or enhancement label Apr 10, 2024
@drichar drichar added this to the v3.0.0 stable release milestone Apr 10, 2024
@drichar drichar self-assigned this Apr 10, 2024
@drichar drichar added the v3 label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or enhancement v3
Projects
None yet
Development

No branches or pull requests

1 participant