Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated root-level options #397

Closed
ark120202 opened this issue Feb 13, 2019 · 5 comments
Closed

Remove deprecated root-level options #397

ark120202 opened this issue Feb 13, 2019 · 5 comments
Labels
discussion Open for discussion and ideas enhancement

Comments

@ark120202
Copy link
Contributor

This removes the need to add lua before option names and would look better if more options would be added.

{
	"lua": { // or tstl
	 	"target": "5.3",
	    "libImport": "inline"
	}
}

Another module that extends tsconfig, awesome-typescript-loader, is doing the same.

@Perryvw
Copy link
Member

Perryvw commented Feb 13, 2019

Looks like an interesting idea, but why not create a luaconfig.json instead then?

@lolleko
Copy link
Member

lolleko commented Feb 13, 2019

I don't think it matters much if its in its own object or just in the config root. Might be slightly nicer to have them grouped. But such a change would break all existing projects, which kinda sucks.

Im absolutely against having another config file, that will just make things more messy and harder to maintain imo.

@Perryvw Perryvw added the discussion Open for discussion and ideas label Feb 13, 2019
@ark120202
Copy link
Contributor Author

But such a change would break all existing projects

Can't it be the same as with old compiler directives? Deprecate old names, use them as a fallback and remove in 1.0.0 (#365).

Im absolutely against having another config file

+1 on this, most projects already have quite a number of config files.

@Perryvw
Copy link
Member

Perryvw commented Feb 13, 2019

I think indeed a path forward would be to support both for a while and eventually get rid of the global settings. I also agree another setting file might just end up cluttering the root of the project (look at the stuff in this project alone).

@ark120202
Copy link
Contributor Author

Supported since #463 and root-level options were deprecated in #511.

@ark120202 ark120202 changed the title Move custom options in tsconfig to the top-level object Remove deprecated root-level options May 5, 2019
@Perryvw Perryvw closed this as completed May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Open for discussion and ideas enhancement
Projects
None yet
Development

No branches or pull requests

3 participants