fix: isExternal flag wasn't set properly

TypeStrong · Nov 26, 2020 · 0060eb7 · 0060eb7
1 parent 9f89bed
commit 0060eb7
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/src/lib/converter/context.ts b/src/lib/converter/context.ts
@@ -6,6 +6,7 @@ import {
     ContainerReflection,
     DeclarationReflection,
     ReflectionKind,
+    ReflectionFlag,
 } from "../models/index";
 
 import type { Converter } from "./converter";
@@ -150,6 +151,9 @@ export class Context {
     ) {
         const reflection = new DeclarationReflection(name, kind, this.scope);
         this.addChild(reflection);
+        if (this.converter.isExternal(symbol)) {
+            reflection.setFlag(ReflectionFlag.External);
+        }
         this.registerReflection(reflection, symbol);
 
         this.converter.trigger(

diff --git a/src/lib/converter/converter.ts b/src/lib/converter/converter.ts
@@ -384,6 +384,11 @@ export class Converter extends ChildableComponent<
             return false;
         }
 
+        return this.isExternal(symbol);
+    }
+
+    /** @internal */
+    isExternal(symbol: ts.Symbol) {
         this.externalPatternCache ??= createMinimatch(this.externalPattern);
         for (const node of symbol.getDeclarations() ?? []) {
             if (

diff --git a/src/lib/models/reflections/abstract.ts b/src/lib/models/reflections/abstract.ts
@@ -432,6 +432,11 @@ export abstract class Reflection {
         this.name = name;
         this.originalName = name;
         this.kind = kind;
+
+        // If our parent is external, we are too.
+        if (parent?.flags.isExternal) {
+            this.setFlag(ReflectionFlag.External);
+        }
     }
 
     /**