fix: Accessor with a set signature was converted incorrectly

TypeStrong · Nov 28, 2020 · 1200212 · 1200212
1 parent 5de3bf5
commit 1200212
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/src/lib/converter/symbols.ts b/src/lib/converter/symbols.ts
@@ -819,7 +819,7 @@ function convertAccessor(
             setDeclaration
         );
         if (signature) {
-            reflection.getSignature = createSignature(
+            reflection.setSignature = createSignature(
                 rc,
                 ReflectionKind.SetSignature,
                 signature,

diff --git a/src/test/converter/class/specs-with-lump-categories.json b/src/test/converter/class/specs-with-lump-categories.json
@@ -3072,6 +3072,19 @@
               "kindString": "Accessor",
               "flags": {},
               "getSignature": [
+                {
+                  "id": 187,
+                  "name": "name",
+                  "kind": 524288,
+                  "kindString": "Get signature",
+                  "flags": {},
+                  "type": {
+                    "type": "intrinsic",
+                    "name": "string"
+                  }
+                }
+              ],
+              "setSignature": [
                 {
                   "id": 188,
                   "name": "name",
@@ -3124,7 +3137,7 @@
               "kind": 262144,
               "kindString": "Accessor",
               "flags": {},
-              "getSignature": [
+              "setSignature": [
                 {
                   "id": 193,
                   "name": "writeOnlyName",

diff --git a/src/test/converter/class/specs.json b/src/test/converter/class/specs.json
@@ -3068,6 +3068,19 @@
               "kindString": "Accessor",
               "flags": {},
               "getSignature": [
+                {
+                  "id": 187,
+                  "name": "name",
+                  "kind": 524288,
+                  "kindString": "Get signature",
+                  "flags": {},
+                  "type": {
+                    "type": "intrinsic",
+                    "name": "string"
+                  }
+                }
+              ],
+              "setSignature": [
                 {
                   "id": 188,
                   "name": "name",
@@ -3120,7 +3133,7 @@
               "kind": 262144,
               "kindString": "Accessor",
               "flags": {},
-              "getSignature": [
+              "setSignature": [
                 {
                   "id": 193,
                   "name": "writeOnlyName",