fix: Negative literal types were converted incorrectly

Resolves #1427
TypeStrong · Dec 29, 2020 · c14b5b5 · c14b5b5
1 parent 38d8edf
commit c14b5b5
Show file tree

Hide file tree

Showing 3 changed files with 110 additions and 80 deletions.
diff --git a/src/lib/converter/types.ts b/src/lib/converter/types.ts
@@ -730,7 +730,7 @@ const literalTypeConverter: TypeConverter<
 
         return requestBugReport(context, node.literal);
     },
-    convertType(context, type, node) {
+    convertType(_context, type, node) {
         switch (node.literal.kind) {
             case ts.SyntaxKind.StringLiteral:
                 return new LiteralType(node.literal.text);
@@ -753,7 +753,7 @@ const literalTypeConverter: TypeConverter<
             );
         }
 
-        return requestBugReport(context, type);
+        return new LiteralType(type.value);
     },
 };
 
@@ -897,7 +897,7 @@ function requestBugReport(context: Context, nodeOrType: ts.Node | ts.Type) {
     } else {
         const typeString = context.checker.typeToString(nodeOrType);
         context.logger.warn(
-            `Failed to convert type: ${typeString}. Please report a bug.`
+            `Failed to convert type: ${typeString} when converting ${context.scope.getFullName()}. Please report a bug.`
         );
         return new UnknownType(typeString);
     }

diff --git a/src/test/converter/types/general.ts b/src/test/converter/types/general.ts
@@ -10,3 +10,6 @@ export type NumArray = number[];
 export const numArray = makeValue<number[]>();
 
 export type BigIntAlias = bigint;
+
+export type NegativeOne = -1;
+export const negativeOne = -1;