Fixed skipping of nested object literals with --excludeNotExported

[alalonde]

Should fix #901, #953 and #958.

[Gerrit0]

Thanks for adding the tests to ensure this doesn't break in the future, I'm a bit worried about the mechanism used to ensure they are exported though...

[Gerrit0]

This worries me. Is there a reason we can't set the isExported flag on containers when creating them instead of this?

[alalonde]

Yeah, I looked into that. That does seem like the more "correct" way to go about it. However, after extensive debugging I discovered that this factory function doesn't ever get called for object literals themselves. Instead, I believe the associated Declaration is created here: https://github.com/TypeStrong/typedoc/blob/master/src/lib/converter/types/reference.ts#L127

Perhaps there is an underlying issue where object literal declarations follow a different code path. I didn't want to go there, so I just wrote some tests to determine the least invasive fix, which is what you see.

Happy to dive back in if you can provide some additional insights about code structure. It's a pretty challenging codebase. :)

[Gerrit0]

Makes sense, thanks. I would like to fix this the right way, but haven't had enough time to dig in and see where that would be yet, so unfortunately I can't provide any guidance here. Maybe next weekend.

Yes, the codebase is rather difficult to follow, we're working on it, but its slow going. :)

[Gerrit0]

I spent some time digging in to this and was able to mostly fix it by inheriting the isExported flag from the parent in createParameter, createSignature, TypeLiteralConverter.convert, and ReferenceConverter.convert. I then realized that I recognized a lot of the changes I was making from #801. I suspect that PR also fixes this issue. Since I've been trying to get through it for like a month, I think I'll put my investigation here on hold and just go tackle that, and after getting it merged in see if it has fixed this issue (I'll at least want to add a test like the one you added, unless #801 adds one already)

[alalonde]

OK, makes sense. Thanks for looking into it. Happy to help with that one where I can.

[alalonde]

@Gerrit0 I pulled #801 and added my test to it. The main converter test (with my added export-literals) passed, but the same test with the excludeNotExported flag set still fails, so I imagine you'll need to add the changes you mentioned above into that branch as well. Or, if you push your changes thus-far to this branch, I can try them out.

[Gerrit0]

Good to know, thanks. I'll be sure to pull your test in when I look into this this weekend.

[Gerrit0]

Sorry about the delay here! I've confirmed that this is fixed in 0.16.0-8 (@next release, full release later today I hope) due to the work with export declarations.