Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate json file for index search #1252

Merged
merged 2 commits into from Apr 5, 2020

Conversation

sgrishchenko
Copy link
Contributor

This is implementation of #1251.
Here I added additional file in JSON format and wrote warning for custom themes, which use JS format. JS file was not removed for backward compatibility. Next step: to support this changes in typedoc-default-themes package.

Copy link
Collaborator

@Gerrit0 Gerrit0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really want to include extra files, especially ones as large as search.js tends to be... I'll hold off on merging this until seeing what the theme changes look like.

src/lib/output/plugins/JavascriptIndexPlugin.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@Gerrit0 Gerrit0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll hold off on merging to merge the theme PR as well so that we keep a working build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants