Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support search without requiring a web server #1339

Closed
Gerrit0 opened this issue Jul 31, 2020 · 0 comments
Closed

Feat: Support search without requiring a web server #1339

Gerrit0 opened this issue Jul 31, 2020 · 0 comments
Labels
enhancement Improved functionality help wanted Contributions are especially encouraged

Comments

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jul 31, 2020

Search Terms

search.js, search index not available

Problem

See #1247 (comment)

Is there a strong reason for the removal of this search.js? Being able to open the files directly in my browser is a quick way to make sure the pages load as expected. I don't know how much work it is to maintain it, but it seems like it introduces friction to have to spin up a server just to load what would otherwise be static HTML files. - @Fleker

Suggested Solution

Partially revert #1252, creating search.js instead of search.json, and loading that in the theme with a <script defer tag. document.write shouldn't be required.

@Gerrit0 Gerrit0 added enhancement Improved functionality help wanted Contributions are especially encouraged labels Jul 31, 2020
@Gerrit0 Gerrit0 added this to To do in Version 0.20 via automation Nov 2, 2020
@Gerrit0 Gerrit0 moved this from To do to In progress in Version 0.20 Nov 2, 2020
@Gerrit0 Gerrit0 moved this from In progress to Done in Version 0.20 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved functionality help wanted Contributions are especially encouraged
Projects
No open projects
Development

No branches or pull requests

1 participant