Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect template parameter default values and use them as type arguments #1348

Merged
merged 27 commits into from Aug 23, 2020
Merged

Reflect template parameter default values and use them as type arguments #1348

merged 27 commits into from Aug 23, 2020

Conversation

krisztianb
Copy link
Contributor

@krisztianb krisztianb commented Aug 15, 2020 •
edited

Fixes #1341 and Fixes #1345

When reviewing please take a closer look at the changes here: https://github.com/TypeStrong/typedoc/compare/master...krisztianb:fix-react-template-parameters?expand=1#diff-6fc223c798b8302651796c1b41fa064a

There is a strange code regarding mixins there. I'm not entirely sure that my logic is correct.

@krisztianb
Changed convert logic for map type
474606f
@krisztianb
Undo changes of last commit: Changed convert logic for map type
294a675
@krisztianb
No need to convert defaultValue for options of type map
58fb056
@krisztianb
Added test for map declaration option with foreign default value
cf16a00
@krisztianb
Merge branch 'master' of https://github.com/TypeStrong/typedoc
f9b73a4
@krisztianb
Added possible min and max values for a number declaration
3095a52
@krisztianb
Merge branch 'master' of https://github.com/TypeStrong/typedoc
52eeb65
@krisztianb
Error message creation extracted into a helper function.
1fa1bd1
@krisztianb
Merge branch 'master' of https://github.com/TypeStrong/typedoc
95bf83d
@krisztianb
Fixed test for map declaration with foreign default value
dc33b99
@krisztianb
Merge branch 'master' of https://github.com/TypeStrong/typedoc
1b5fcc8
@krisztianb
Allow every possible number as a defaultValue for a number option
52d6e26
@krisztianb
Fix indent
1b0a71e
@krisztianb
Merge branch 'master' of https://github.com/TypeStrong/typedoc
d3761d4
@krisztianb
Add defaultType to TypeParameterType
a42ac8a
@krisztianb
Use defaults for type parameters when inheriting
99a5510
@krisztianb
Simpler check for undefined
c064fd9
@krisztianb
Move methods to utils
134bae7
@krisztianb
Fix: return in forEach is no good
0984316
@krisztianb
Merge branch 'master' of https://github.com/TypeStrong/typedoc
4283fa6
@krisztianb
Merge branch 'master' into fix-react-template-parameters
707fc63
@krisztianb
Rename defaultType to default
c154ae3
@krisztianb
Fix mixin test specs
80120fe
@krisztianb
Combine type parameters of all mixin types
9aa5e35
@krisztianb
Fix converter alias test
2516f8a
@krisztianb
Interfaces can have type parameters too
1f36591
Gerrit0
Gerrit0 reviewed Aug 16, 2020
View reviewed changes
Copy link
Collaborator

@Gerrit0 Gerrit0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike the special casing that we do for mixins... It is incredibly difficult to follow. I think what you did will work correctly.

src/lib/converter/utils/types.ts Outdated Show resolved Hide resolved
src/lib/converter/utils/types.ts Outdated Show resolved Hide resolved
src/lib/converter/utils/types.ts Outdated Show resolved Hide resolved
src/lib/converter/utils/types.ts Show resolved Hide resolved
src/lib/converter/utils/types.ts Outdated Show resolved Hide resolved
@Gerrit0 Gerrit0 merged commit f67f8db into TypeStrong:master Aug 23, 2020
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Aug 23, 2020

Thanks! Hoping to get a release out tonight.

@krisztianb krisztianb deleted the fix-react-template-parameters branch August 24, 2020 09:46
@krisztianb krisztianb mentioned this pull request Aug 24, 2020
Merged
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Aug 28, 2020

Released in 0.19 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit0 Gerrit0 Gerrit0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@krisztianb @Gerrit0