Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private property shown as public method #1452

Closed
arv opened this issue Jan 4, 2021 · 1 comment
Closed

Private property shown as public method #1452

arv opened this issue Jan 4, 2021 · 1 comment
Labels
bug Functionality does not match expectation

Comments

@arv
Copy link

arv commented Jan 4, 2021

Search terms

private class property public method

Expected Behavior

When generating docs it should not show private properties when excludePrivate is set to true.

Actual Behavior

It fails to mark a private property as private. Instead it is listed as a public method

Steps to reproduce the bug

Given code like this:

private _onStorage = (e: StorageEvent): void => {

https://github.com/arv/replicache-sdk-js/blob/147b0d932aa32f8066a9dcdeb78b601103e03ed6/src/replicache.ts#L223

On branch https://github.com/arv/replicache-sdk-js/tree/typedoc-0.20

You can repro this by running npm run doc and then npx http-server docs and checking out the generated documentation for the default export.

Environment

  • Typedoc version: 0.20.11
  • TypeScript version: 4.1.3
  • Node.js version: v15.5.1
  • OS: macOS 11.1
@arv arv added the bug Functionality does not match expectation label Jan 4, 2021
@Gerrit0 Gerrit0 closed this as completed in 9b4f898 Jan 5, 2021
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 5, 2021

Fixed in 0.20.12, thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

No branches or pull requests

2 participants