Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Failed to convert type" when re-exporting a wildcard import #1453

Closed
christopherthielen opened this issue Jan 4, 2021 · 2 comments
Closed
Labels
bug Functionality does not match expectation

Comments

@christopherthielen
Copy link
Contributor

I ran across this error when updating typedoc-plugin-external-module-name to 0.20. My plugin's functional tests re-export a named splat import from a child module.

Search terms

Failed to convert type when re-exporting a named wildcard import

Actual Behavior

Warning: Failed to convert type: typeof import("/Users/cthielen/projects/downstream-cache/test/src/annotations/dir1/index") when converting reexport_dir1. Please report a bug.

Steps to reproduce the bug

import * as dir1 from './dir1';
export const reexport_dir1 = dir1;

clone and test:

git clone git@github.com:christopherthielen/typedoc-plugin-external-module-name.git
cd typedoc-plugin-external-module-name
git checkout bugreport
yarn
npx typedoc src/index.ts

Environment

  • Typedoc version: 0.20.11
  • TypeScript version: 4.1.3
  • Node.js version: 12.16.0
  • OS: big sur
@christopherthielen christopherthielen added the bug Functionality does not match expectation label Jan 4, 2021
@Gerrit0 Gerrit0 closed this as completed in 37e8a3c Jan 5, 2021
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 5, 2021

Fixed in 0.20.12, thanks for the report!

I wasn't entirely sure what to use as the names for these reference types... including user paths in docs isn't great. I opted for __module, unless it was a type in the form of import("x").Y, in which case I use Y.

@christopherthielen
Copy link
Contributor Author

thank you @Gerrit0 for your attentiveness to this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

No branches or pull requests

2 participants