Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bin script to terminate gracefully #1461

Merged
merged 1 commit into from Jan 8, 2021
Merged

Update bin script to terminate gracefully #1461

merged 1 commit into from Jan 8, 2021

Conversation

krisztianb
Copy link
Contributor

@Gerrit0 Gerrit0 merged commit 0d892ce into TypeStrong:master Jan 8, 2021
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 8, 2021

Thanks!

@krisztianb krisztianb deleted the bin-script-update branch January 8, 2021 08:09
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Aug 25, 2023

I am reverting this change -- it previously allowed working around a lack of places to properly place async creation/cleanup work, but I believe the use case which required this is now covered by preRenderAsyncJobs and postRenderAsyncJobs, if that doesn't cover it, some other hook needs creating

@krisztianb
Copy link
Contributor Author

Thanks for letting me know. I will have a look.

@krisztianb krisztianb mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krisztianb @Gerrit0