Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commonjs default export doesn't work #1476

Closed
hugomrdias opened this issue Jan 22, 2021 · 3 comments
Closed

commonjs default export doesn't work #1476

hugomrdias opened this issue Jan 22, 2021 · 3 comments
Labels
bug Functionality does not match expectation

Comments

@hugomrdias
Copy link

Search terms

Expected Behavior

commonjs default export could be merged with the named exports namespace and listed in the nav with some kinda of sign just to tell the users which are named and default.

Actual Behavior

commonjs default shows up has export= and any other types or exports are not resolved. Check example 1 below

Steps to reproduce the bug

  1. https://codesandbox.io/s/typedoc-test-w69ry?file=/src/index.js

  2. https://codesandbox.io/s/typedoc-test-w69ry?file=/src/named.js

Environment

  • Typedoc version: 0.20.16
  • TypeScript version: 4.1.3
  • Node.js version: 14
  • OS: all
@hugomrdias hugomrdias added the bug Functionality does not match expectation label Jan 22, 2021
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 23, 2021

module.exports = isn't a default export. It's equivalent to TypeScript's export =.

Fixed with 4a539dd

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 23, 2021

Fix released in 0.20.17

@hugomrdias
Copy link
Author

Thank you this is awesome!! Now I can change "export=" to whatever I want with a plug-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

No branches or pull requests

2 participants