Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private static getters being displayed with excludePrivates: true #1516

Closed
zajrik opened this issue Feb 22, 2021 · 2 comments · Fixed by arvinxx/components#25
Closed

Private static getters being displayed with excludePrivates: true #1516

zajrik opened this issue Feb 22, 2021 · 2 comments · Fixed by arvinxx/components#25
Labels
bug Functionality does not match expectation

Comments

@zajrik
Copy link

zajrik commented Feb 22, 2021

Search terms

Expected Behavior

I expected the private static getter to not be output in the documentation because I have excludePrivates: true in my config
image

Actual Behavior

The private static getter is being output in the documentation
image

Steps to reproduce the bug

Generate documentation for the following code with excludePrivates: true in the config:

export class Test
{
	private static get _test(): string
	{
		return 'test';
	}

	public test(): string
	{
		return Test._test;
	}
}

Environment

  • Typedoc version: 0.20.23
  • TypeScript version: 4.1.3
  • Node.js version: 14.15.3
  • OS: Ubuntu 20.04.2 LTS on Windows 10 x86_64

I'm just using /** @internal */ as a workaround for the time being but hopefully this can be resolved. Thank you.

@zajrik zajrik added the bug Functionality does not match expectation label Feb 22, 2021
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 23, 2021

I like easy bugs :) Just forgot to call the setModifiers function for accessors.

@zajrik
Copy link
Author

zajrik commented Feb 23, 2021

Awesome! Thanks for the quick fix!

zajrik added a commit to discord-samba/command that referenced this issue Feb 23, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment