Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Marked to 2.0.x #1601

Closed
Fleker opened this issue Jun 16, 2021 · 3 comments · Fixed by #1602
Closed

Pin Marked to 2.0.x #1601

Fleker opened this issue Jun 16, 2021 · 3 comments · Fixed by #1602
Labels
bug Functionality does not match expectation

Comments

@Fleker
Copy link
Contributor

Fleker commented Jun 16, 2021

Search terms

Marked, Node 10

Expected Behavior

I expect installing Typedoc in my project as a dependency, using Node 10, will work as expected.

Actual Behavior

My CI system reports an error and breaks due to a change in the Marked minimum version from Node 8+ to Node 12+. As I am installing via Node 10, the build fails.

+ yarn
# ...
error marked@2.1.1: The engine "node" is incompatible with this module. Expected version ">= 12". Got "10.18.0"
error Found incompatible module.

A resolution to the issue would be pinning the Marked dependency to ~2.0.3 if and until Marked's engines field is returned to something >= 10.18.0 or lower.

Steps to reproduce the bug

  • Start with an environment using Node 10 (nvm use 10.18.0)
  • Create a project with a dependency of typedoc@^0.20.0 or marked@^2.00
  • Run yarn
@Fleker Fleker added the bug Functionality does not match expectation label Jun 16, 2021
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jun 16, 2021

Node 10 is dead. It's not supported anymore by Node. v0.21 removes it from TypeDoc's supported versions as well. If you want to submit a PR for 0.20, go ahead, but I'm likely not going to get around to this before 0.21, and I don't support versions older than latest due to time constraints.

@Fleker
Copy link
Contributor Author

Fleker commented Jun 16, 2021

I will submit a PR for v0.20, as this issue breaks out project's build and I'd like that to be fixed promptly rather than go through a larger major release process.

Fleker added a commit to Fleker/typedoc that referenced this issue Jun 16, 2021
Allows installation to complete successfully on Node 10.8.0

Fixes TypeStrong#1601
Gerrit0 pushed a commit that referenced this issue Jun 16, 2021
Allows installation to complete successfully on Node 10.8.0

Fixes #1601
@Fleker
Copy link
Contributor Author

Fleker commented Jun 17, 2021

I appreciate your quick turnaround on this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants