Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin marked dependency to 2.0.x #1602

Merged
merged 1 commit into from Jun 16, 2021
Merged

Pin marked dependency to 2.0.x #1602

merged 1 commit into from Jun 16, 2021

Conversation

Fleker
Copy link
Contributor

@Fleker Fleker commented Jun 16, 2021

Allows installation to complete successfully on Node 10.8.0

Fixes #1601

@Fleker
Pin marked dependency to 2.0.x
f5b5a6f 
Allows installation to complete successfully on Node 10.8.0

Fixes TypeStrong#1601
@Fleker
Copy link
Contributor Author

Fleker commented Jun 16, 2021

Tested by running yarn on fresh clone, saw error:

error marked@2.1.1: The engine "node" is incompatible with this module. Expected version ">= 12". Got "10.20.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Added patch and ran yarn again. It completed successfully.

@Gerrit0 Gerrit0 merged commit 0e8d429 into TypeStrong:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin Marked to 2.0.x
2 participants
@Fleker @Gerrit0