Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--excludeNotDocumented should not create empty pages #1607

Closed
Primajin opened this issue Jun 23, 2021 · 3 comments
Closed

--excludeNotDocumented should not create empty pages #1607

Primajin opened this issue Jun 23, 2021 · 3 comments
Labels
bug Functionality does not match expectation

Comments

@Primajin
Copy link

Search terms

excludeNotDocumented empty page

Expected Behavior

When running typedoc src --excludeNotDocumented I expect folders that only include undocumented files to not create empty pages in typedoc

Actual Behavior

Typedoc still creates a link / page for every folder, rendering a complete useless blank page

Steps to reproduce the bug

image

Environment

  • Typedoc version: 0.21.0
  • TypeScript version: 4.3.4
  • Node.js version: v16.3.0
  • OS: Windows
@Primajin Primajin added the bug Functionality does not match expectation label Jun 23, 2021
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jun 23, 2021

That's strange... I thought we had logic to check for that in the renderer. Should be an easy fix at least.

@Primajin
Copy link
Author

I ran it together with another exclude pattern (to exlude files under the folder "mock-data") if that helps reproducing somehow.

@Primajin
Copy link
Author

Perfect, I can confirm that 0.21.1 fixed the issue 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

No branches or pull requests

2 participants