Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support githubprivate.com in GitHubPlugin #1743

Merged
merged 1 commit into from Oct 22, 2021

Conversation

nlfurniss
Copy link
Contributor

Some Github Enterprise clients have a githubprivate.com domain, and this supports that

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Oct 22, 2021

Is there some GitHub documentation somewhere where I can look up what domains GH enterprise can use? I've had no luck finding any, wondering if there's other ones that are missing.

@nlfurniss
Copy link
Contributor Author

Is there some GitHub documentation somewhere where I can look up what domains GH enterprise can use? I've had no issue finding any, wondering if there's other ones that are missing.

Sadly I couldn't find any either 😕. I also fixed the prettier issues

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Oct 22, 2021

Oh well, I guess it'll just get improved as people find more problems then, thanks!

@Gerrit0 Gerrit0 merged commit 6fbeb50 into TypeStrong:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants