Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links to protected members do not work without first changing "Member Visibility" #2092

Closed
bd82 opened this issue Nov 3, 2022 · 4 comments
Closed
Labels
bug Functionality does not match expectation help wanted Contributions are especially encouraged

Comments

@bd82
Copy link

bd82 commented Nov 3, 2022

Search terms

  • Member Visibility
  • Protected

Expected Behavior && Actual Behavior

Given a link to a protected member I would expect it to "just" work.
But if the "Member Visibility" has not been set with "protected" enabled.
The link will not work.

Note that by default protected members are hidden so links to protected/private members will
simply not work...

Steps to reproduce the bug

You can also reproduce this using the super simple repo which includes my settings and config.

Environment

"typedoc": "0.23.19",
"typescript": "4.7.4",
  • Node.js version: 18.4.0
  • OS: Win11
@bd82 bd82 added the bug Functionality does not match expectation label Nov 3, 2022
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 3, 2022

Bleh :/ this is going to be annoying to fix. The best fix is probably to take you where it should be, and show you a prompt that indicates it's hidden because of settings, ideally with something to click to make it show up...

@Gerrit0 Gerrit0 added the help wanted Contributions are especially encouraged label Nov 3, 2022
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 3, 2022

Temporary workaround: you can set visibilityFilters to default protected members to visible.

@bd82
Copy link
Author

bd82 commented Nov 4, 2022

Thanks.
I applied the workaround, although it did seem like I had to clear cache / hard-reload in
my browser for it to be applied.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 4, 2022

That filter preference is stored in localStorage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation help wanted Contributions are especially encouraged
Projects
None yet
Development

No branches or pull requests

2 participants